updated for shared memory support. #328
Conversation
updated for shared memory support.
There was a problem hiding this comment.
Thanks! One general comment that I have is that this changes the command line params for test_gdiplus.exe, so if we reference it anywhere in the documentation (IIRC we do in a couple of places, e.g. https://github.com/googleprojectzero/winafl/blob/master/readme_dr.md but possibly others), the documentation will be out-of-date and should be updated as well.
gdiplus.cpp
Outdated
| IStream* stream = SHCreateMemStream(reinterpret_cast<BYTE*>(sample_bytes), sample_size); | ||
| image = Gdiplus::Image::FromStream(stream); | ||
| } | ||
| if (image && (Ok == image->GetLastStatus())) { |
There was a problem hiding this comment.
Indentation seems to be off here
There was a problem hiding this comment.
trying multiple options.. but for some reasons its just not working..
gdiplus.cpp
Outdated
| IStream* stream = SHCreateMemStream(reinterpret_cast<BYTE*>(sample_bytes), sample_size); | ||
| image = Gdiplus::Image::FromStream(stream); | ||
| } | ||
| if (image && (Ok == image->GetLastStatus())) { |
There was a problem hiding this comment.
trying multiple options.. but for some reasons its just not working..
|
For me, it shows as having a 2 tab indentation whereas the line before has a single tab. |
updated for shared memory support.